-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building for WASM #213
Comments
Hi, thank you for your interest in this library, and apologies for the delay. I'm not very familiar with WASM, honestly, so I'm not familiar with the limitations which are in place when using it. Looking at the What did you have in mind as replacement |
I think the simplest solution would be just to use the same |
@flimzy your pull request would be very welcome here. If you find time to submit it, Ross or I can give it a look. I apologize for our delayed reaction. Your initial message arrived in a vacation season and I am sure that our reaction time will be much better now. |
At present, this package fails to build for WASM:
This is due to the fact that github.com/coder/websocket exposes different
DialOptions
structs for WASM than for other targets. There is an issue open that would address at least some of this, but it's old and hasn't gotten much attention.Unless/until
github.com/coder/websocket
addresses this issue, is it reasonable forgo-grpc-http1
to put theDialOptions
use behind a build tag, so that it can compile for web assembly?I'm happy to submit a pull request if it's likely to be accepted.
The text was updated successfully, but these errors were encountered: