Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix untyped flash data #137

Open
ssube opened this issue Nov 11, 2019 · 0 comments
Open

fix untyped flash data #137

ssube opened this issue Nov 11, 2019 · 0 comments
Assignees
@ssube
Labels
scope/visitor status/progress issues that are in progress type/bug
Milestone
v0.9

Comments

@ssube
Copy link
Owner

ssube commented Nov 11, 2019 •
edited
Loading

The context data used to pass selected item index and rule name down is untyped and not particularly flexible.

Passing arbitrary data down will never be possible to type well, but using context hooks (#21) to pass errors and diffs up as they are encountered will allow the friendly messaging to happen in a more appropriate place. Since that place will know what rule produced the messages, it could even call some sort of Rule.format method.
@ssube ssube self-assigned this Nov 11, 2019
@ssube ssube added this to the v0.9 milestone Nov 11, 2019
ssube added a commit that referenced this issue Nov 19, 2019
@ssube
fix: type rule visitor flash data (fixes #137)
8c5eab2
@ssube ssube mentioned this issue Nov 19, 2019
Closed
@ssube ssube added status/progress issues that are in progress and removed status/new labels Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssube ssube

Labels
scope/visitor status/progress issues that are in progress type/bug
Projects
None yet
Milestone
v0.9
Development

Successfully merging a pull request may close this issue.

WIP: emit visitor events ssube/salty-dog
1 participant
@ssube