Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'apply' of undefined #634

Open
christianbundy opened this issue Feb 6, 2019 · 6 comments
Open

Cannot read property 'apply' of undefined #634

christianbundy opened this issue Feb 6, 2019 · 6 comments

Comments

@christianbundy
Copy link
Contributor

christianbundy commented Feb 6, 2019

Can someone give me a sanity check when you get a minute?

With ssb-server running somewhere (CLI, Patchwork, Patchbay, etc), I'm getting this instead of the usual help text:

$ node bin.js
Cannot read property 'apply' of undefined

I can still do things like node bin get $msg_key but the default help text is completely borked for me. I've tried rolling back to 13.x but I'm still getting the same issue, which makes me think it must just be me. Right?

asciicast

@lachenmayer
Copy link
Contributor

I get this as well when I run any command that should render a help message, eg. ssb-server --help.

@dominictarr
Copy link
Contributor

I think this was usage which was a casualty in the recent modularization. normally running sbot without anything would have dumped the full help text (which was too much to be useful, really)

@christianbundy
Copy link
Contributor Author

@dominictarr
Copy link
Contributor

lets say, hypothetically, we had really really good cli usage? what would it look like?
ideas:

  • missing a required option would print a short warning about the command you were trying to use, and the required options.
  • ssb-server help command... would print a long detailed message.
  • an unknown command would print a list of commands (extra points: that seemed similar to the command you used)

some limitations are that each command is in it's own module, so the help should probably live there?

@dominictarr
Copy link
Contributor

oh yeah, I think you still see this now when you have a more recent version of ssb-server running as the client, that interacts with and older version of ssb-server (prehaps running inside of patchbay/work) that doesn't have help methods.

@christianbundy christianbundy removed their assignment Jan 31, 2021
@stale
Copy link

stale bot commented Jun 2, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the stale label Jun 2, 2021
@staltz staltz removed the stale label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants