Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide dockerfile for builds #34

Open
jdbohrman opened this issue Oct 5, 2018 · 2 comments
Open

Provide dockerfile for builds #34

jdbohrman opened this issue Oct 5, 2018 · 2 comments

Comments

@jdbohrman
Copy link

Per #33 I think it would be prudent to provide a dockerfile to containerize the app and allow for smoother testing and deployment. See https://docs.travis-ci.com/user/docker/ for reference.

@asb-capfan
Copy link
Collaborator

I have to admit, I don't see the benefit of creating a dockerfile for this Perl module.
Tests are easily done by forging input and expecting output. After all, that's "all" what the module does.
The deployment is user-specific anyway and there is no safe way to cover all DataTables scenarios that could exists (just have a look at all the examples here: https://datatables.net/examples/index).

It sounds like a lot of work with little to no effect.
However, if somebody else does the work - why not.

@srchulo
Copy link
Owner

srchulo commented Oct 6, 2018

@jdbohrman , could you explain what you think that would offer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants