-
Notifications
You must be signed in to change notification settings - Fork 109
Remove calls to UDFs whose index is being used #187
Comments
Blocked until indexes are implemented in gitbase |
This would require implementing rule phases, because this would require the squash rule to be done before assigning indexes. Right now either you mess with inserting the rule in a certain position or append it to the end (which is what we're doing). Once that is done, the squash would be done first and the indexes can be assigned to the topmost table of the squash only. Then, we can always remove the expression that produces the index. |
Depends on #141 |
I created src-d/gitbase#318 to keep track of the part that concerns gitbase. There are some details there worth taking into account with this task. |
Blocked again until further discussion, see src-d/gitbase#318 |
This is not blocked anymore. |
How is this not blocked? We can't still do this because of the squashed tables. |
Right, misreading. |
Right now, expression with used indexes are not being removed. They should be to avoid expensive calls to some UDFs.
They are not removed right now because it might clash with the squash joins rule. We need to implement this in a way that does not break that rule.
The text was updated successfully, but these errors were encountered: