Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Remove calls to UDFs whose index is being used #187

Open
erizocosmico opened this issue May 9, 2018 · 8 comments
Open

Remove calls to UDFs whose index is being used #187

erizocosmico opened this issue May 9, 2018 · 8 comments
Labels
blocked Some other issue is blocking this performance Performance improvements

Comments

@erizocosmico
Copy link
Contributor

Right now, expression with used indexes are not being removed. They should be to avoid expensive calls to some UDFs.

They are not removed right now because it might clash with the squash joins rule. We need to implement this in a way that does not break that rule.

@erizocosmico erizocosmico added the performance Performance improvements label May 9, 2018
@erizocosmico erizocosmico added the blocked Some other issue is blocking this label May 24, 2018
@erizocosmico
Copy link
Contributor Author

Blocked until indexes are implemented in gitbase

@ajnavarro ajnavarro added this to the Index-2 milestone Jun 13, 2018
@erizocosmico
Copy link
Contributor Author

This would require implementing rule phases, because this would require the squash rule to be done before assigning indexes. Right now either you mess with inserting the rule in a certain position or append it to the end (which is what we're doing).

Once that is done, the squash would be done first and the indexes can be assigned to the topmost table of the squash only.

Then, we can always remove the expression that produces the index.

@ajnavarro
Copy link
Contributor

Depends on #141

@erizocosmico erizocosmico self-assigned this Jun 19, 2018
@erizocosmico erizocosmico removed the blocked Some other issue is blocking this label Jun 19, 2018
@erizocosmico
Copy link
Contributor Author

I created src-d/gitbase#318 to keep track of the part that concerns gitbase. There are some details there worth taking into account with this task.

@erizocosmico
Copy link
Contributor Author

Blocked again until further discussion, see src-d/gitbase#318

@erizocosmico erizocosmico added the blocked Some other issue is blocking this label Jun 19, 2018
@ajnavarro ajnavarro removed the blocked Some other issue is blocking this label Jul 5, 2018
@ajnavarro
Copy link
Contributor

This is not blocked anymore.

@erizocosmico
Copy link
Contributor Author

How is this not blocked? We can't still do this because of the squashed tables.

@ajnavarro ajnavarro added the blocked Some other issue is blocking this label Jul 5, 2018
@ajnavarro
Copy link
Contributor

Right, misreading.

@ajnavarro ajnavarro removed this from the Index-2 milestone Aug 1, 2018
@erizocosmico erizocosmico removed their assignment Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked Some other issue is blocking this performance Performance improvements
Projects
None yet
Development

No branches or pull requests

2 participants