Allow contributing bindings with generic supertypes #726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of giving up, whenever user attempts to
@Contributes(Multi)Binding
on a generic parent interface, it will just bind to a variant of the parent interface with generic parameters filled as stars.It does not cover all use cases, but it covers more use cases than the old solution. And user can still use regular Module to achieve the rest of the use cases (like before), so this seems like a win win in my book.
This fixes #694.