Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dagger assisted injection: Type projection broken since Anvil 2.4.3 #686

Open
consp1racy opened this issue Feb 9, 2023 · 2 comments
Open
Labels
bug Something isn't working dagger factory Happens when generateDaggerFactories is set to true

Comments

@consp1racy
Copy link

Given

class CachingSerialNumbers @AssistedInject constructor(
    private val store: DataStore<SerialNumber?>,
    @Assisted actual: @JvmSuppressWildcards Provider<out SerialNumbers>,
) : SerialNumbers {

    @AssistedFactory
    interface Factory {

        fun create(actual: @JvmSuppressWildcards Provider<out SerialNumbers>): CachingSerialNumbers
    }

    // ...
}

Anvil 2.4.2 generates working

public class CachingSerialNumbers_Factory(
  private val store: Provider<@JvmSuppressWildcards DataStore<SerialNumber?>>,
) {
  public fun `get`(`actual`: @JvmSuppressWildcards Provider<out SerialNumbers>):
      CachingSerialNumbers = newInstance(store.get(), actual)

  public companion object {
    @JvmStatic
    public fun create(store: Provider<@JvmSuppressWildcards DataStore<SerialNumber?>>):
        CachingSerialNumbers_Factory = CachingSerialNumbers_Factory(store)

    @JvmStatic
    public fun newInstance(store: @JvmSuppressWildcards DataStore<SerialNumber?>,
        `actual`: @JvmSuppressWildcards Provider<out SerialNumbers>): CachingSerialNumbers =
        CachingSerialNumbers(store, actual)
  }
}

and Anvil 2.4.3 generates

public class CachingSerialNumbers_Factory(
  private val store: Provider<@JvmSuppressWildcards DataStore<SerialNumber?>>,
) {
  public fun `get`(`actual`: Provider<@JvmSuppressWildcards SerialNumbers>): CachingSerialNumbers =
      newInstance(store.get(), actual)

  public companion object {
    @JvmStatic
    public fun create(store: Provider<@JvmSuppressWildcards DataStore<SerialNumber?>>):
        CachingSerialNumbers_Factory = CachingSerialNumbers_Factory(store)

    @JvmStatic
    public fun newInstance(store: @JvmSuppressWildcards DataStore<SerialNumber?>,
        `actual`: Provider<@JvmSuppressWildcards SerialNumbers>): CachingSerialNumbers =
        CachingSerialNumbers(store, actual)
  }
}

which fails with

> Task [...]:compileKotlin FAILED
e: [...]\build\anvil\src-gen-main\[...]\CachingSerialNumbers_Factory_Impl.kt: (23, 27): Type mismatch: inferred ty
pe is Provider<out SerialNumbers> but Provider<SerialNumbers> was expected

Because Anvil generates Kotlin source from Kotlin source, the annotations and projections need to be copied verbatim.

@vRallev
Copy link
Collaborator

vRallev commented Feb 9, 2023

Maybe related to #647

@vRallev vRallev added bug Something isn't working dagger factory Happens when generateDaggerFactories is set to true labels Feb 9, 2023
@consp1racy
Copy link
Author

Dirty workaround

class CachingSerialNumbers @AssistedInject constructor(
    private val store: DataStore<SerialNumber?>,
    @Assisted actual: Provider<SerialNumbers>,
) : SerialNumbers {

    @AssistedFactory
    interface Factory {

        fun createImpl(actual: Provider<SerialNumbers>): CachingSerialNumbers

        @Suppress("UNCHECKED_CAST")
        fun create(actual: @JvmSuppressWildcards Provider<out SerialNumbers>): CachingSerialNumbers {
            return createImpl(actual as Provider<SerialNumbers>)
        }
    }

    // ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dagger factory Happens when generateDaggerFactories is set to true
Projects
None yet
Development

No branches or pull requests

2 participants