Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undoing "remove" on an atomic block restores the selection in the wrong location #141

Open
thibaudcolas opened this issue Feb 26, 2018 · 0 comments
Open

Undoing "remove" on an atomic block restores the selection in the wrong location #141

thibaudcolas opened this issue Feb 26, 2018 · 0 comments
Labels
bug Something isn't working
Milestone
Nice to have

Comments

@thibaudcolas
Copy link
Collaborator

Bug. On "undo" after removing an atomic block (image/embed "Remove" using onRemoveEntity), the selection should be restored where it was before:

What is the current behavior?

image-remove-selection-undo

What is the expected behavior?

Selection should be on the right of ggg.

Which versions of Draftail + Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draftail or Draft.js?

This comes with bb740ab. I haven't found a way to implement this for wagtail/wagtail#4296 without this issue.
@thibaudcolas thibaudcolas added the bug Something isn't working label Feb 26, 2018
@thibaudcolas thibaudcolas added this to the Post v1.0.0 milestone Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Nice to have
Development

No branches or pull requests
1 participant
@thibaudcolas