Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concourse extension doesn't know about check_every for a resource type #382

Closed
marco-m opened this issue Oct 22, 2019 · 3 comments
Closed
Milestone

Comments

@marco-m
Copy link

marco-m commented Oct 22, 2019

Consider this pipeline snippet:

resource_types:

- name: cogito
  type: registry-image
  check_every: 24h          # <=== error reported here
  source:
    repository: ((docker-registry))/cogito

The extension wrongly reports

Unknown property 'check_every' for type 'ResourceType'

The documentation about check_every for resource types is: https://concourse-ci.org/resource-types.html#resource-type-check-every

@kdvolder
Copy link
Member

Going through the doc of the 'resource_type' I am finding a few other missing attributes in our schema. Alltogether these are missing:

  • check_every
  • params
  • tags
  • unique_version_history

I'll add support for these as well while I'm at it.

@kdvolder
Copy link
Member

Implemented without validation inside params for the time being. But when/if I get a clear answer to my query (concourse/docs#273) I'll probably add more validation. If so I will raise a new ticket for this.

@marco-m
Copy link
Author

marco-m commented Nov 1, 2019

thanks @kdvolder !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants