Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing page_viewed Partial #69

Open
SylarRuby opened this issue Jan 15, 2023 · 6 comments
Open

Missing page_viewed Partial #69

SylarRuby opened this issue Jan 15, 2023 · 6 comments
Labels

Comments

@SylarRuby
Copy link

SylarRuby commented Jan 15, 2023

Is this compatible with Spree v4.5.0? Got an error about missing partial when view the legacy frontend:

spree/shared/trackers/google_analytics/page_viewed.js

I cannot see a this file inside this repo. What happened after Spree v3.4?

@kimsrung
Copy link

I'm facing the same issue for spree v4.5.0.

@runlevel5
Copy link
Contributor

You have to specify what error you got.

From my understanding the page_viewed.js is rendered from /app/views/spree/shared/trackers/google_analytics/_page_viewed.js.erb

@kimsrung
Copy link

kimsrung commented Jun 29, 2023

Here is the error message.

Missing partial spree/shared/trackers/google_analytics/_page_viewed.js with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :jbuilder, :rabl]}.

image

@runlevel5 runlevel5 added the bug label Jul 20, 2023
@runlevel5
Copy link
Contributor

Yes I can confirm this issue on Spree 4.5.0.

Bug fix is greatly welcomed

@stap780
Copy link

stap780 commented Sep 29, 2023

I use this fix

JuanseGimenez@c947cd8

@mbajur
Copy link
Contributor

mbajur commented Apr 25, 2024

It should be fixed on master via #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants