Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios: DNS override, hard to tell when deleting an entry #306

Open
0vercl0k opened this issue Apr 5, 2024 · 9 comments
Open

ios: DNS override, hard to tell when deleting an entry #306

0vercl0k opened this issue Apr 5, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@0vercl0k
Copy link

0vercl0k commented Apr 5, 2024

On the iOS app, when trying to delete a DNS override entry, it is pretty hard to click on the red ❌ button as it is small; and somehow you also don't get any feedback when a click has been dispatched. That plus a small lag lead to clicking several times in a row and deleting multiple entries.

I can probably try to make a video if that's useful, but it wouldn't even be visible when I am tapping on the screen so not sure it'd be super useful.

Cheers

@0vercl0k 0vercl0k changed the title ios: DNS overide, hard to tell when deleting an entry ios: DNS override, hard to tell when deleting an entry Apr 5, 2024
@0vercl0k
Copy link
Author

I also noticed that this control is also used in the DNS logging settings UI and it has the same effect; you never know when you properly the ❌ and sometime end up deleting two entries when you wanted to delete one

lts-po pushed a commit that referenced this issue Apr 18, 2024
@lts-po
Copy link
Collaborator

lts-po commented Apr 18, 2024

Pushed a new version to TestFlight with a swipelist similar to device listing - check if this is better. Plan is if it works, we move more of the listings to this layout for iOS (blocklists, rules, groups, any listing) & add more buttons to the hidden view.

Thanks again!

lts-rad added a commit that referenced this issue Apr 18, 2024
* [ui] fix mobile for hostname

* [api] return json if config

* [ui] ClientSelect Policy support, use globe icon for Group

* [build] docker has introduced a bug with relative paths and files, address with PWD

* [api] Remove wpa2 workaround for apple devices

* [api] [dhcp] Do not DHCP from WANIF

* [ui] cleanup flex/mobile. fix #308

* [ui] listItem as component

* [ui] swipeList for ios

* [ui] use swipelist for ios, see #306

---------

Co-authored-by: lts-po <po@longterm.io>
@0vercl0k
Copy link
Author

Woot this is looking great!

@0vercl0k
Copy link
Author

The 'Dns Log Settings' / 'Host Privacy IP List' seems to have the old little red ❌; not sure if it was missed or it regressed somehow?

@lts-rad
Copy link
Contributor

lts-rad commented May 10, 2024

looking into it now, this view disappeared from routes and wasnt rendering properly on web. as for whyios is not picking up the swipelist im not sure. i dont actually see a code change for settings for using DNSOverrideListItem which got the swipe list in 340b5df

@lts-rad
Copy link
Contributor

lts-rad commented May 10, 2024

xcrun is currently failing for the PR. https://github.com/spr-networks/super/actions/runs/9026717967/job/24804460927 . its possible testflight is grabbing the wrong version

@lts-rad
Copy link
Contributor

lts-rad commented May 10, 2024

the dns override at least has it, so im thinking maybe it didnt make it to the log settings previously

@lts-rad lts-rad added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels May 10, 2024
@lts-rad
Copy link
Contributor

lts-rad commented Aug 1, 2024

is this resolved now? as of v0.3.14

@0vercl0k
Copy link
Author

0vercl0k commented Aug 4, 2024

This is fixed in the DNS override view yes, but it isn't fixed in the 'DNS Log > Log Settings > Host Privacy IP List' view (same on v0.3.14 as well).

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants