-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ios: DNS override, hard to tell when deleting an entry #306
Comments
I also noticed that this control is also used in the DNS logging settings UI and it has the same effect; you never know when you properly the ❌ and sometime end up deleting two entries when you wanted to delete one |
Pushed a new version to TestFlight with a swipelist similar to device listing - check if this is better. Plan is if it works, we move more of the listings to this layout for iOS (blocklists, rules, groups, any listing) & add more buttons to the hidden view. Thanks again! |
* [ui] fix mobile for hostname * [api] return json if config * [ui] ClientSelect Policy support, use globe icon for Group * [build] docker has introduced a bug with relative paths and files, address with PWD * [api] Remove wpa2 workaround for apple devices * [api] [dhcp] Do not DHCP from WANIF * [ui] cleanup flex/mobile. fix #308 * [ui] listItem as component * [ui] swipeList for ios * [ui] use swipelist for ios, see #306 --------- Co-authored-by: lts-po <po@longterm.io>
Woot this is looking great! |
The 'Dns Log Settings' / 'Host Privacy IP List' seems to have the old little red ❌; not sure if it was missed or it regressed somehow? |
looking into it now, this view disappeared from routes and wasnt rendering properly on web. as for whyios is not picking up the swipelist im not sure. i dont actually see a code change for settings for using DNSOverrideListItem which got the swipe list in 340b5df |
xcrun is currently failing for the PR. https://github.com/spr-networks/super/actions/runs/9026717967/job/24804460927 . its possible testflight is grabbing the wrong version |
the dns override at least has it, so im thinking maybe it didnt make it to the log settings previously |
is this resolved now? as of v0.3.14 |
This is fixed in the DNS override view yes, but it isn't fixed in the 'DNS Log > Log Settings > Host Privacy IP List' view (same on v0.3.14 as well). Cheers |
On the iOS app, when trying to delete a DNS override entry, it is pretty hard to click on the red ❌ button as it is small; and somehow you also don't get any feedback when a click has been dispatched. That plus a small lag lead to clicking several times in a row and deleting multiple entries.
I can probably try to make a video if that's useful, but it wouldn't even be visible when I am tapping on the screen so not sure it'd be super useful.
Cheers
The text was updated successfully, but these errors were encountered: