Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store dtype in metadata of memmap #119

Open
cwmeijer opened this issue Jul 29, 2021 · 0 comments
Open

Store dtype in metadata of memmap #119

cwmeijer opened this issue Jul 29, 2021 · 0 comments

Comments

@cwmeijer
Copy link
Contributor

cwmeijer commented Jul 29, 2021

This is about save_audio_features_to_memmap function in utils/preprocessing.py.

Would be way safer to store the dtype in the metadata of the memmap
so that we'd be sure to use the same dtype in dataset.py
If we don't use the same dtype in dataset.py, we'll end up with reading random
segments of the memory /!\ Not performed this way for LibriVox, so I did the same
for SpokenCOCO

@bhigy, I moved your code comment to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant