Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spfs clean fails if disk is full #923

Open
jrray opened this issue Nov 28, 2023 · 2 comments · May be fixed by #1159
Open

spfs clean fails if disk is full #923

jrray opened this issue Nov 28, 2023 · 2 comments · May be fixed by #1159
Labels
bug Something isn't working

Comments

@jrray
Copy link
Collaborator

jrray commented Nov 28, 2023

When the local spfs repository is located on a disk that is very full, spfs clean will fail with "No space left on device" if the user running the command does not already have a renders directory. As the only way to open a local repository is to ultimately create it, this involves attempting to create a number of directories, including the per-user renders directory.

This has to be worked around by either running the clean as a different user that already has a renders directory, or manually removing some files to free up enough space to let clean run normally.

The clean command has no need for that renders directory to exist, but there is currently no way for clean to just open an existing repo in a "read only" way.

@jrray jrray added the bug Something isn't working label Nov 28, 2023
@rydrman
Copy link
Collaborator

rydrman commented Nov 29, 2023

From the meeting today:

  • the solution is likely some kind of type state or other delayed creation of the renders area until the logic flow requires it. Ie the clean code would never invoke that portion because it never tries to render anything.

@jrray
Copy link
Collaborator Author

jrray commented Dec 11, 2024

#1159 will address this issue.

@jrray jrray linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants