New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed pipeline plan should have a return code of 1 #13

Open

nextrevision opened this issue Dec 1, 2017 · 1 comment

nextrevision commented Dec 1, 2017

Whenever a pipeline-template plan fails due to an invalid template the return code is still 0 (see https://github.com/spinnaker/roer/blob/master/actions.go#L234). This makes testing templates in a CI system much harder.

Would be great if we could have a RC of 1

Contributor

benjaminws commented Mar 14, 2018

If I'm not mistaken, this was fix up by #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment