Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to pass options to shim? #115

Open
matsbror opened this issue May 14, 2024 · 5 comments
Open

How to pass options to shim? #115

matsbror opened this issue May 14, 2024 · 5 comments

Comments

@matsbror
Copy link

I need to run spin with the --disable-pooling option because my RISCV64 and Aarch64 boards only have 39 bit virtual addresses and thus cannot make the 6T mmap that Wasmtime pooling allocator makes. How can I pass that option to the shim?

@vdice
Copy link
Contributor

vdice commented May 14, 2024

I'll let @jsturtevant and/or other maintainers chime in re: generic wasmtime or spin runtime configurability but I did want to mention that there happens to be a recent PR in Spin relating to the specific use case mentioned above. See fermyon/spin#2508. The intention there is to not require any specific config for running properly in such environments as mentioned above (i.e. it should dynamically disable pooling) . When the shim bumps to the future Spin release with the aforementioned logic included, specific wasmtime/Spin config should no longer be necessary for this scenario.

@jsturtevant
Copy link
Contributor

We don't have a story right now for passing configuration to the shim to configure the underlying runtime. Would spin's runtime-config.toml be an appropriate place for this? Another option might be via https://github.com/WebAssembly/wasi-runtime-config?

Potentially, we could do something with containerd/runwasi#573 but need some more design work on how to make that generic.

@radu-matei
Copy link
Member

@matsbror I think this issue is addressed in fermyon/spin#2508 specifically.

The broader context for other config options that we would pass is still relevant though.

@matsbror
Copy link
Author

My issue has been resolved so the issue can be closed, but I think there could be a need to pass config options to the shim, still.

@calebschoepp
Copy link
Contributor

I also have a need to pass config options to the shim. Specifically I want to be able to set the environment variables RUST_LOG and OTEL_EXPORTER_OTLP_ENDPOINT for the Shim.

As a SpinKube user I'd love to be able to set these values in my SpinApp CR, but I'm not sure if that is possible or the right design choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants