Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSupport ignores doctreedir argument #54

Open
liborjelinek opened this issue Dec 11, 2017 · 2 comments
Open

WebSupport ignores doctreedir argument #54

liborjelinek opened this issue Dec 11, 2017 · 2 comments
Labels

Comments

@liborjelinek
Copy link

WebSupport class accepts doctreedir where .doctree files are placed. By default it should be <builddir>/doctrees/ where buildir is another WebSupport class parameter.

However I've noticed that doctreedir argument is ignored in the source code. Specifically in the sphinxcontrib.websupport.core.py:58 is this line

self.doctreedir = staticdir or path.join(self.builddir, 'doctrees')

I.e. doctrees are created under specified staticdir. It shoudl respect constructor parameter:

self.doctreedir = doctreedir or path.join(self.builddir, 'doctrees')
@liborjelinek
Copy link
Author

What to do the next? It's very easy to fix. I can create PR that fixes it but I don't know how to write test for it...

@tk0miya tk0miya added the bug label Dec 15, 2017
@tk0miya
Copy link
Member

tk0miya commented Dec 15, 2017

Yes, please. We always welcome your PR!

I can create PR that fixes it but I don't know how to write test for it...

I also don't know that. So please test it locally on creating PR.

@AA-Turner AA-Turner transferred this issue from sphinx-doc/sphinx Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants