-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation improvements for 1.0 release #1620
Open
FrankRay78
wants to merge
5
commits into
spectreconsole:main
Choose a base branch
from
FrankRay78:Documentation_improvements_for_version_1.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Documentation improvements for 1.0 release #1620
FrankRay78
wants to merge
5
commits into
spectreconsole:main
from
FrankRay78:Documentation_improvements_for_version_1.0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankRay78
changed the title
Documentation improvements for 1.0 release (WIP)
Documentation improvements for 1.0 release
Aug 24, 2024
@patriksvensson I've addressed your earlier review comments and rebased against main, fixing conflicts. This PR is now ready for another review +/ merging. IMPORTANT: The following PR spectreconsole/examples#1 should be reviewed/merged at the same time as this one. |
…s a custom class the user must provide.
FrankRay78
force-pushed
the
Documentation_improvements_for_version_1.0
branch
from
September 17, 2024 10:24
281a16a
to
8ec71c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR spectreconsole/examples#1 should be reviewed/merged at the same time as this one.
fixes #1602
OR no documentation changes are required.Changes
Please upvote 👍 this pull request if you are interested in it.