Skip to content
This repository has been archived by the owner on Aug 4, 2019. It is now read-only.

Multipart is not set when a ratelimiter is not used. #2

Open
nickelc opened this issue Jul 13, 2019 · 1 comment · May be fixed by #4
Open

Multipart is not set when a ratelimiter is not used. #2

nickelc opened this issue Jul 13, 2019 · 1 comment · May be fixed by #4

Comments

@nickelc
Copy link

nickelc commented Jul 13, 2019

RestClient::request<T>()

spectacles-rs/rest/src/lib.rs

Lines 279 to 281 in 3b9d4a7

let req = self.http.request(endpt.method.clone(), &req_url)
.query(&endpt.query)
.json(&endpt.json);

RestClient::request_empty()

spectacles-rs/rest/src/lib.rs

Lines 316 to 318 in 3b9d4a7

let req = self.http.request(endpt.method.clone(), &req_url)
.query(&endpt.query)
.json(&endpt.json);

@nomsi
Copy link
Member

nomsi commented Jul 14, 2019

Until the async/.await()? release QoL changes like this are not really necessary.

spectacles-rs/rest/src/lib.rs

Lines 369 to 372 in 3b9d4a7

pub fn multipart(mut self, payload: Form) -> Endpoint {
self.multipart = Some(payload);
self
}

This function is here for your use when making large multipart requests in the mean time: I will keep this issue open, you are more than welcome to submit a PR that we can take a look at.

@nickelc nickelc linked a pull request Jul 15, 2019 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set multipart for the case ratelimiter is not used
2 participants
@nickelc @nomsi