Use phpcs phar instead of the full distro
#272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs release - spaze/coding-standard updated from v1.7.0 to v1.7.1 patch See changes: spaze/coding-standard@v1.7.0...v1.7.1 Release notes: https://github.com/spaze/coding-standard/releases/tag/v1.7.1
- squizlabs/php_codesniffer removed (installed version was 3.8.1) - dealerdirect/phpcodesniffer-composer-installer removed (installed version was v1.0.0) - spaze/phpcs-phar installed in version 3.8.1 Release notes: https://github.com/spaze/phpcs-phar/releases/tag/3.8.1
Not using the dealerdirect plugin because it doesn't work with the phar release, see why here https://github.com/spaze/phpcs-phar#installing-coding-standards I've first installed the standard with ``` vendor/bin/phpcs --config-set installed_paths ../../slevomat/coding-standard ``` and then edited the file to add `__DIR__` and more as described here https://github.com/spaze/phpcs-phar#modify-the-config-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it's less files and the 9P filesystem as used by WSL2 doesn't like many small files performance-wise. I also wanted to learn a bit more GitHub Actions to see if such thing would be possible, and it turns out it is.
Maybe one day PHPCS will see an official phar release, see PHPCSStandards/PHP_CodeSniffer#318 for some more info.
This required an update of my coding standard to omit setting
installed_pathsconfig in the ruleset file.Also, the dealerdirect/phpcodesniffer-composer-installer plugin is removed because the custom phar distribution doesn't work with it now, reasons mentioned in the README. I had to install the slevomat/coding-standard manually and update the config file to use an absolute path, as documented.