Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor link for vscode to detect file / remote from link #899

Open
joshbmarshall opened this issue Mar 22, 2024 · 0 comments
Open

Editor link for vscode to detect file / remote from link #899

joshbmarshall opened this issue Mar 22, 2024 · 0 comments

Comments

@joshbmarshall
Copy link

** Background **
I have a mix of local and remote codebases I work on. So some will require the editor link for vscode to use vscode://file/ and some require vscode://vscode-remote/

Describe the bug
Using "vscode" as the editor only uses vscode://file/ so only works with local files.
If I change to a Custom URL and use vscode://vscode-remote/%path:%line then it works for remote codebases but not local files

Versions
Ray version 2.7.5

You can use composer show to get the version numbers of:

  • spatie/ray package version: 1.37.7
    PHP version:
    8.3

To Reproduce
Steps to reproduce the behavior:
When using editor as VSCode:

  1. Click on a file:line link in the ray output from remote system
  2. See error that /ssh-remote+hostname... does not exist on this computer

When using editor with Custom URL vscode://vscode-remote/%path:%line

  1. Click on a file:line link in the ray output from local system
  2. See prompt that asks if I want to open vscode-remote:/home/... when I click Yes, nothing happens (does not open file)

Expected behavior
The VSCode editor option should auto-detect when the ssh-remote+ or wsl+ etc are at the start of the local_path and use vscode://vscode-remote/ prefix instead of vscode://file/ prefix

Desktop (please complete the following information):

  • OS: Manjaro Linux
  • Version 2024-03-22

Additional Information
I tried setting the Custom URL to be vscode://%path:%line and setting the local_path to be 'file/home/...' or 'ssh-remote+hostname...' but when I click on the link, it doesn't even bring up vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant