Error when loading snapshot

[jnkodo]

I used the .sql.gz file and then this happened

[ECMT-t-fujii]

I think this is an event that occurs only in the case of gz and steam when doing load with stream option.
It is caused by the lack of consideration for the gz case in the following places.

laravel-db-snapshots/src/Snapshot.php

Lines 94 to 126 in 872b9e7

	$stream = $this->disk->readStream($this->fileName);
	$statement = '';
	while (! feof($stream)) {
	$chunk = $this->compressionExtension === 'gz'
	? gzdecode(gzread($stream, self::STREAM_BUFFER_SIZE))
	: fread($stream, self::STREAM_BUFFER_SIZE);
	$lines = explode("\n", $chunk);
	foreach ($lines as $idx => $line) {
	if ($this->shouldIgnoreLine($line)) {
	continue;
	}
	$statement .= $line;
	// Carry-over the last line to the next chunk since it
	// is possible that this chunk finished mid-line right on
	// a semi-colon.
	if (count($lines) == $idx + 1) {
	break;
	}
	if (substr(trim($statement), -1, 1) === ';') {
	yield $statement;
	$statement = '';
	}
	}
	}
	if (substr(trim($statement), -1, 1) === ';') {
	yield $statement;
	}

The following dirty patch will solve the problem.

            $statement = '';

            if ($this->compressionExtension === 'gz') {
                $stream = gzopen($this->disk->path($this->fileName), "rb");
                while(!gzeof($stream)) {
                    $chunk = gzread($stream, self::STREAM_BUFFER_SIZE);

                    $lines = explode("\n", $chunk);
                    foreach($lines as $idx => $line) {
                        if ($this->shouldIgnoreLine($line)) {
                            continue;
                        }

                        $statement .= $line;

                        // Carry-over the last line to the next chunk since it
                        // is possible that this chunk finished mid-line right on
                        // a semi-colon.
                        if (count($lines) == $idx + 1) {
                            break;
                        }

                        if (substr(trim($statement), -1, 1) === ';') {
                            yield $statement;
                            $statement = '';
                        }
                    }
                }
                gzclose($stream);
            } else {
                $stream = $this->disk->readStream($this->fileName);

                $statement = '';
                while(!feof($stream)) {
                    $chunk = fread($stream, self::STREAM_BUFFER_SIZE);

                    $lines = explode("\n", $chunk);
                    foreach($lines as $idx => $line) {
                        if ($this->shouldIgnoreLine($line)) {
                            continue;
                        }

                        $statement .= $line;

                        // Carry-over the last line to the next chunk since it
                        // is possible that this chunk finished mid-line right on
                        // a semi-colon.
                        if (count($lines) == $idx + 1) {
                            break;
                        }

                        if (substr(trim($statement), -1, 1) === ';') {
                            yield $statement;
                            $statement = '';
                        }
                    }
                }
            }

            if (substr(trim($statement), -1, 1) === ';') {
                yield $statement;
            }

Sorry I don't have time to contribute by fixing the TestCase.

[jnkodo]

I replaced the code in the source file by yours, but the error remains

[jnkodo]

The dump is always done, but I always find some error messages into log file, take a look on picture

[tomas-doudera]

Hello, did you resolve the problem? I have same issue.

[jnkodo]

Don't use compression method Le lun. 20 mars 2023, 13:29, Tomáš Douděra ***@***.***> a écrit :

…

Hello, did you resolve the problem? I have same issue. — Reply to this email directly, view it on GitHub <#132 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3ZM7NGNJV2QJ7HKOF6AGILW5APQZANCNFSM6AAAAAASB36MGY> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>