Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for unixsockets (empty domains) #7

Open
mzachh opened this issue Jul 13, 2015 · 0 comments
Open

Support for unixsockets (empty domains) #7

mzachh opened this issue Jul 13, 2015 · 0 comments

Comments

@mzachh
Copy link

mzachh commented Jul 13, 2015

There are tests which check for a valid domain, e.g.: https://github.com/sparklemotion/http-cookie/blob/master/lib/http/cookie.rb#L572
Thats good, but it is a blocker if http is used over a unixsocket.
Is there a possiblity to work around this test on a proper way?

For quick testing I just replaced the "raise" in line 572 with "true", which "fixes" the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant