Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distro-specific php.ini templates #254

Open
hrak opened this issue Aug 21, 2019 · 1 comment
Open

Remove distro-specific php.ini templates #254

hrak opened this issue Aug 21, 2019 · 1 comment
Labels
Feature Request Enhancement to existing functionality or new functionality hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event Maintenance Maintenance issues such as failing builds Priority: Low Is a nice to have, not an essential

Comments

@hrak
Copy link
Contributor

hrak commented Aug 21, 2019

🗣️ Foreword

Thank for taking the time to fill this feature request fully. Without it we may not be able to , and the issue may be closed without resolution.

🙍 Problem Statement

After #250 was merged, i noticed that this cookbook supplies distro-specific php.ini templates for debian, ubuntu, centos and redhat. Things could be greatly simplified by removing these and, if needed at all, set any distro-specific ini defaults in a different way using the default template.

This issue was also addressed in #150 but this issue got closed due to inactivity.

❔ Possible Solution

Remove distro-specific php.ini templates. If needed at all, set any distro-specific ini defaults in a different way using the default template.

⤴️ Describe alternatives you've considered

Update all of the distro specific templates too as addressed in #250 but that seems very cludgy.

➕ Additional context

#150
#250

@damacus damacus added Feature Request Enhancement to existing functionality or new functionality Maintenance Maintenance issues such as failing builds Priority: Low Is a nice to have, not an essential labels Feb 20, 2020
@damacus
Copy link
Member

damacus commented Feb 20, 2020

Hey @hrak that sounds great. If you want to give fix this a go, pleas feel free!

@ramereth ramereth added the hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event label Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Enhancement to existing functionality or new functionality hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event Maintenance Maintenance issues such as failing builds Priority: Low Is a nice to have, not an essential
Projects
None yet
Development

No branches or pull requests

3 participants