Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access repository over SFTP transport #83

Open
1 of 7 tasks
sourcefrog opened this issue Jan 20, 2020 · 1 comment · May be fixed by #232
Open
1 of 7 tasks

Access repository over SFTP transport #83

sourcefrog opened this issue Jan 20, 2020 · 1 comment · May be fixed by #232

Comments

@sourcefrog
Copy link
Owner

sourcefrog commented Jan 20, 2020

Following on from #13, access the repository over SFTP, probably using https://docs.rs/ssh2/.

This is mostly implemented in https://github.com/sourcefrog/conserve/tree/sftp.

The code for this works in a branch, but not on the released version of SSH2, because of alexcrichton/ssh2-rs#251.

Releasing this in Conserve was blocked on alexcrichton/ssh2-rs#278, a new release of SSH2 that includes the fixes for readdir, but that is now fixed.

Still to do:

  • Use the released version of ssh2.
  • Merge up to master.
  • Make the dependency optional?
  • Document that SSH support exists
  • Set a default remote username the same as the local username: at present the default is "" which is rejected with an unclear message
  • At least, document that authentication is only from an ssh-agent
  • Add some option to permit authentication other than by an agent: a key file, password, etc?

Alternatively, SSH could be supported based on https://docs.rs/openssh-sftp-client/latest/openssh_sftp_client/ and https://docs.rs/openssh/0.10.1/openssh/. That would

  • Only work on Unix.
  • Respect all your local configuration of SSH, since it literally runs external ssh.
  • Authenticate in whatever way is configured in to SSH, without needing every method to be specifically supported in Conserve.
@sourcefrog
Copy link
Owner Author

There is now https://docs.rs/openssh-sftp-client/latest/openssh_sftp_client/ which might be more promising:

  • Uses external ssh to authenticate so will inherit configuration
  • May be more actively maintained?

@sourcefrog sourcefrog linked a pull request Dec 3, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant