Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sass support #52

Open
floviolleau opened this issue Oct 19, 2016 · 4 comments
Open

Add sass support #52

floviolleau opened this issue Oct 19, 2016 · 4 comments

Comments

@floviolleau
Copy link

Hi,

Could it be possible to add sass support when you will add #51?

Kind regards.

@floviolleau
Copy link
Author

floviolleau commented Oct 19, 2016

Finally, I just did it here:
https://github.com/floviolleau/npm-round-slider

Best regards

@soundar24
Copy link
Owner

Is SCSS really needed now ? Since we are going to SCSS when the file size was huge, so that we can organize the styles through multiple mixins and nested rules simply.

But already the current CSS was in formatted way, also the user won't need to change any physical styles. They only needed to change the appearance related colors, that also we can achieve through the playground simply:
http://roundsliderui.com/playground.html

So that I planned to do this in future.

@floviolleau
Copy link
Author

Ok no problems. But I use SASS in my projects and it has a better integration rather than using css :).

I rewrote entirely the lib to make it understandable and avoid one line conditionals and one line var declaration.
I started to add a multiple handles support. The last thing remaining is to correctly manage path colors and test it

@soundar24
Copy link
Owner

Good thing... If possible you can add some test scripts, since I already planned but not started still.. so that any future commits can be tested easily..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants