-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename an undefined variable #7876
Labels
enhancement
New feature or surprising current feature
IDE
Relating to Sorbet's LSP server or VS Code extension
Comments
qaisjp
added
bug
Something isn't working
unconfirmed
This issue has not yet been confirmed by the Sorbet team
labels
May 7, 2024
jez
added
enhancement
New feature or surprising current feature
IDE
Relating to Sorbet's LSP server or VS Code extension
and removed
bug
Something isn't working
unconfirmed
This issue has not yet been confirmed by the Sorbet team
labels
May 7, 2024
While the feature request is admirable, I worry that there's no convenient way to implement this in Sorbet. I'm happy for someone to prove me wrong, but I would not hold out hope for this to get fixed soon. |
It's worth noting that TypeScript doesn't appear to implement this feature either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or surprising current feature
IDE
Relating to Sorbet's LSP server or VS Code extension
Input
→ View on sorbet.run
Press F2 on
pr
and typepull_ctx
in the rename prompt.Observed output
In Visual Studio Code, I get:
Expected behavior
The rename should work.
Instead, I have to add a
pr = nil
, then renamepr
, and then delete the new line.The text was updated successfully, but these errors were encountered: