Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT/#297] 배너 목록 조회 기능 구현 #298

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

[FEAT/#297] 배너 목록 조회 기능 구현 #298

wants to merge 8 commits into from

Conversation

yummygyudon
Copy link
Member

작성 중 (12.28 21:00)

Related Issue 🚀

Work Description ✏️

  • 배너 목록 조회 기능 구현

PR Point 📸

@yummygyudon
[CHORE] PublishPeriod & BannerImage 도메인 builder 적용
cb35cc9
@yummygyudon
[FIX] PublishStatus 도메인 Enum 메서드 오류 수정
f09630b 
- 잘못된 Return Type 수정
@yummygyudon
[FEAT] 배너 목록 조회 API 정의
b0c1546
@yummygyudon
[FEAT] Banner 목록 조회 API Success / Failure Code 정의
efedc20 
2가지 조회 Request Parameter 오류에 대한 Failure Code를 선언했습니다.
- Filter 파라미터
- Sort 파라미터
@yummygyudon
[FEAT] Banner 목록 조회 Service 메서드 구현
81e553e 
요청에 따른 동적 Filtering & Sorting 분기가 필요해 SQL Query를 통한 동적 쿼리 적용보다 Application 단에서의 조건 분기로 처리하는 것이 적합하다고 생각하여 메서드를 통한 전처리를 진행했습니다.
@yummygyudon
[FEAT] Banner 목록 조회 API 구현
7e9ea08
@yummygyudon
[TEST] 배너 조회 정상 처리 및 의도 결과 반환 여부 확인 TEST
43a04ec 
- 복수의 초기 데이터가 필요해 정적 SQL 파일을 통해 Dummy Data를 주입했습니다.
@yummygyudon
[REFACTOR] 전체 조회에 대한 Filter 요청에 대해 Early Return 적용
8328cd7
@yummygyudon yummygyudon requested a review from hyunw9 December 28, 2024 11:59
@yummygyudon yummygyudon linked an issue Dec 28, 2024 that may be closed by this pull request
[FEAT] 배너 - 목록 조회 #297
Open
3 tasks
@height Height
Copy link

height bot commented Dec 28, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyunw9 hyunw9 Awaiting requested review from hyunw9

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 배너 - 목록 조회
1 participant
@yummygyudon