Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code line preview doesn't work with GET parameters #128

Open
dgw opened this issue Jul 21, 2023 · 0 comments
Open

Code line preview doesn't work with GET parameters #128

dgw opened this issue Jul 21, 2023 · 0 comments
Labels

Comments

@dgw
Copy link
Member

dgw commented Jul 21, 2023

GitHub puts the view mode into the URL sometimes when viewing renderable files (Markdown, reST, etc.), which can break sopel-github parsing the link:

<dgw> https://github.com/Exirel/sopel/blob/34777e2500f713b250413b6d3c978004e04497c3/docs/source/tutorials/configurable.rst?plain=1#L65

(That is, Sopel doesn't recognize that it should handle the link.) Compare to the plugin behavior without ?plain=1:

<dgw> https://github.com/Exirel/sopel/blob/34777e2500f713b250413b6d3c978004e04497c3/docs/source/tutorials/configurable.rst#L65
<Sopel> [GitHub] [Exirel/sopel] docs/source/tutorials/configurable.rst @ 34777e2500f713b250413b6d3c978004e04497c3 | L65: bot.say(f'I want a {fruit}!')
@dgw dgw added the bug label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant