Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing implementation of nboutputs for If Operator #1036

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Add missing implementation of nboutputs for If Operator #1036

merged 1 commit into from
Apr 10, 2023

Conversation

7r3nzy
Copy link
Contributor

@7r3nzy 7r3nzy commented Apr 10, 2023 •
edited

Fixes #1029

@7r3nzy 7r3nzy changed the title Draft: Add missing implementation of nboutputs for If Operator Add missing implementation of nboutputs for If Operator Apr 10, 2023
@7r3nzy
Copy link
Contributor Author

7r3nzy commented Apr 10, 2023

@kali could you please take a look?

@7r3nzy 7r3nzy force-pushed the implement-If-nboutputs branch 2 times, most recently from dc5e9ca to 4d14a28 Compare April 10, 2023 10:10
@kali
Copy link
Collaborator

kali commented Apr 10, 2023

Looks good. Just waiting for CI.

@7r3nzy
Copy link
Contributor Author

7r3nzy commented Apr 10, 2023

@kali previous run failed due to a warning on unused import, could you please run the CI again. Thanks.

@kali kali merged commit 8218c76 into sonos:main Apr 10, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kali kali kali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silero-vad-4 needs actual If operator
2 participants
@7r3nzy @kali