-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Context Aware flag in Node #23
Comments
Thank you for the kind words and for linking to Electron’s discussion. I’m not yet sure how much effort it will be to make this addon context-aware but I’ll look into it when time permits. By the way, if you don’t strictly need ICU, I suggest taking a look at ced which serves the same purpose but is significantly simpler to build. |
Thank you for the recommendation. I took a look at |
Have you tried ced with Electron? While it’s indeed also a native module, it uses N-API and therefore should already be compatible with Electron’s change. |
First of all, I have to say this is one of the most reliable character encoding detection package I managed to find, which is why I really want to include it in my Electron project. That said, I want to point out that in the future (not so near but still foreseeable), the Electron team will require native modules to be using NAPI or be Context Aware, as detailed in electron/electron#18397. Could you please consider this direction?
The text was updated successfully, but these errors were encountered: