Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCF BERT inputs #195

Open
dimtsintzou opened this issue Jul 11, 2021 · 1 comment
Open

LCF BERT inputs #195

dimtsintzou opened this issue Jul 11, 2021 · 1 comment

Comments

@dimtsintzou
Copy link

Hi could you please verify which are the inputs for the calculation of lcf_vec?
In your code you use the text_bert_indices
lca_ids, lcf_cdm_vec = get_lca_ids_and_cdm_vec(opt, text_bert_indices, aspect_bert_indices,
aspect_begin, syntactical_dist)
where text_bert_indices=[CLS] + sentence+[SEP]+aspect +[SEP]

However in https://github.com/yangheng95/LCF-ATEPC he uses text_bert_indices=[CLS] + sentence+[SEP]

Thank you

@yangheng95
Copy link
Contributor

Maybe the issue you raised is about the implementation of LCF in PyABSA, because the code you refered is not contained in this repo. However, the text length considered the appended aspect, see here. So, they are the same, excluding some differences in implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants