-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BS5 events not firing #71
Comments
So the same is for any other events.. like |
Hello, the issue here is also impacting the Sauce (SNPT) plugin, even when simply including the hc-offcanvas-nav JS, without performing any instantiation. Specifically the issue kicks in for us when the It's hijacking the clicks for our plugin, seeming due to it overriding the |
Same here on integrating into Magento 2. I agree with @mrjamesriley . The "EventListener" logic probably creates many problems. |
I'll have to re-write this or figure something else for capturing event listeners. |
Hi, the issue also breaks bootstrap 5 modal events. hc-offcanvas is a very nice offcanvas menu and i would like to use it further. i have migrated my template to bootstrp 5. unfortunately it also partially destroys the bootstrap 5 events for me. does anyone have a workaround on how to get this running. |
When
hc-offcanvas-nav
is included, I can't use BS5 eg.shown.bs.tab
event.Check the codepen for example. I added console.log on
shown.bs.tab
event and it does nothing. When I completely removehc-offcanvas-nav
plugin, everything works fine.https://codepen.io/5ulo/pen/mdEVbWY
The text was updated successfully, but these errors were encountered: