Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Modified" date is misleading #233

Closed
VirginiaBalseiro opened this issue May 22, 2024 · 3 comments
Closed

"Modified" date is misleading #233

VirginiaBalseiro opened this issue May 22, 2024 · 3 comments

Comments

@VirginiaBalseiro
Copy link
Member

The page at https://solid.github.io/solid-oidc/ shows a "Modified" date, which is currently listed as April 15. I expected this date to reflect changes or updates in the content. However, it appears that the date is automatically updated with every commit, even when the commits are only related to dependency updates. For instance, on April 15, the only commits made were related to dependency updates.

I believe that the "Modified" date should only be updated when there are actual changes to the content. This would provide a more accurate reflection of when the content was last modified.

@elf-pavlik
Copy link
Member

elf-pavlik commented May 22, 2024

This is an editor's draft, which I consider primarily relevant for active participants. The broader audience should rely on the latest published versions, where the date would reflect when the draft was published.

Do you see a specific, pragmatic problem with the editor's draft having a date of the last commit?

@acoburn
Copy link
Member

acoburn commented May 22, 2024

From a purely practical perspective, what @VirginiaBalseiro describes is not possible with the current structure.

This specification uses BikeShed, and the modification date is updated every time HTML is rendered from the BikeShed source. That rendering happens on every commit, whether that commit changes the contents of the document or whether we update the version of Python that runs in GH actions. But either way, we definitely want that rendering to happen at each commit, since that is how we ensure that the editor's version is an accurate reflection of the source data.

I would advocate closing this issue.

@VirginiaBalseiro
Copy link
Member Author

Do you see a specific, pragmatic problem with the editor's draft having a date of the last commit?

Like I said, I find it confusing that the date does not reflect changes in content, but not a dealbreaker, just a suggestion.

@elf-pavlik elf-pavlik closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants