Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not enough clear expectations on quality and timing of spec and panel reviews #225

Open
justinwb opened this issue Jul 24, 2020 · 2 comments

Comments

@justinwb
Copy link
Member

We're seeing cases both on individual panels and also on solid/specification where there isn't clear definition from the process on when a given pull request can be merged, or the expected quality of that merge based on where it is in the the lifecycle.

Specifically:

  • Simple changes shouldn't require too much process, or seemingly "side-step" the process
  • When things are are in the drafting process, and the draft is still incomplete, there should be a premium on getting feedback in a timely fashion, to advance completion of the draft. Fuller and more in-depth review should always happen when a draft is complete and ready for them.
  • There should be some general protections against having things stagnate without receiving timely review
  • These expectations should be clear for both panel and solid/specification reviews.
@justinwb
Copy link
Member Author

Note that @csarven has proposed some ideas to address these issues.

@RubenVerborgh RubenVerborgh changed the title Not enough clear expectations on quality and timing of reviews Not enough clear expectations on quality and timing of spec and panel reviews Jul 25, 2020
@justinwb
Copy link
Member Author

Renamed this to distinguish from website concerns (#217/#222).

Ah yes this is really something quite different, and wasn't meant to be taken in the same context. A couple of examples are solid/authorization-panel#84 and solid/data-interoperability-panel#57, where we have drafts that are in-progress and incomplete, but we want quick and timely review that can be factored into the next batch of work already underway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant