[Topology.Container] Various clean in TriangleSetGeometryAlgorithms #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epernod
added
pr: status wip
|
[ci-build][with-all-tests] |
hugtalbot
reviewed
May 21, 2024
Comment on lines
-390
to
-401
| template<class Vec> | ||
| bool is_point_on_edge(const Vec& p, const Vec& a, const Vec& b) | ||
| { | ||
| const typename Vec::value_type ZERO = 1e-12; | ||
| Vec v = (p - a).cross(p - b); | ||
|
|
||
| if(v.norm2() < ZERO) | ||
| return true; | ||
| else | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
This method was not used anymore, only declared in the .inl and not correct.
There is a method in Edge.h for that.
hugtalbot
reviewed
May 21, 2024
| if(DO_EXTRADEBUG_MESSAGES){ | ||
| dmsg_info() << "TriangleSetTopology.inl : Cut is not reached because inputs elements are the same element." ; | ||
| } | ||
| msg_warning() << "TriangleSetTopology.inl : Cut is not reached because inputs elements are the same element." ; |
There was a problem hiding this comment.
these are no more debug messages, is this on purpose?
There was a problem hiding this comment.
Yes according to the message this means the cut won't happen. it should be a warning for the user.
fredroy
added
pr: status wip
…ctedObjectList for more clarity
…ath methods to avoid confusion
epernod
force-pushed
the
inf_2024_10_minorTopoClean
branch
from
32d67ff
to
51f1c4d
Compare
epernod
added
pr: status to review
|
[ci-build][with-all-tests] |
fredroy
approved these changes
Jun 5, 2024
bakpaul
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if