Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MechanicalLoad] Update TrianglePressureForceField to remove plan selection and add callback on Data pressure and triangleList #4743

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

epernod
Copy link
Contributor

@epernod epernod commented May 17, 2024

  • Remove all Data and method related to triangle selection on a plan.
    • Data: normal, dmin, dmax
    • Methods: void selectTrianglesAlongPlane(), bool isPointInPlane(Coord p);
  • Merge method selectTrianglesFromString() into initTriangleInformation()
  • Add callback for Data pressure and triangleList
  • Update the example scene to use a BoxROI instead of plan definition on a big yellow beam 😆

image


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels May 17, 2024
@epernod
Copy link
Contributor Author

epernod commented May 17, 2024

[ci-build][with-all-tests]

@hugtalbot
Copy link
Contributor

Remove all Data and method related to triangle selection on a plan.

I guess this should now be done through a ROI?

@epernod
Copy link
Contributor Author

epernod commented May 21, 2024

Remove all Data and method related to triangle selection on a plan.

I guess this should now be done through a ROI?

yes exactly, I already put it in the deprecated message:
core::objectmodel::lifecycle::DeprecatedData normal{ this, "v24.06", "v24.12", "normal", "Plan selection using normal, dmin, dmax has been removed. Triangles should be selected using an Engine.Select and passed using Data triangleList" };

@epernod epernod added this to the v24.06 milestone May 22, 2024
@bakpaul bakpaul modified the milestones: v24.06, v24.12 May 27, 2024
@epernod epernod force-pushed the inf_2024_07_triPressureFF branch from f63820e to d1dc220 Compare May 29, 2024 13:49
@fredroy fredroy merged commit ca70b0f into sofa-framework:master Jun 11, 2024
11 checks passed
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 11, 2024
@epernod epernod deleted the inf_2024_07_triPressureFF branch June 11, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants