-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Use MeshMatrixMass in hyperelastic examples #4687
[examples] Use MeshMatrixMass in hyperelastic examples #4687
Conversation
[ci-build][with-all-tests] |
[ci-build][with-all-tests] |
[ci-depends-on] detected during build #3. To unlock the merge button, you must
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the regression reference and go
[ci-build][with-all-tests] |
[ci-depends-on] detected during build #4. To unlock the merge button, you must
|
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #5. To unlock the merge button, you must
|
[ci-depends-on] detected during build #6. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
LGTM |
[ci-depends-on] detected during build #7. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-build][with-all-tests] |
[ci-depends-on] detected during build #8. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-depends-on] detected during build #9. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
Co-authored-by: Paul Baksic <[email protected]>
Since users often copy paste examples, let's show good scene habits: when modeling volumetric, the MeshMatrixMass should be used instead.
I guess this will trigger the regression tests (but I need to recompile regression first, so I give the CI a chance :) )
[ci-depends-on https://github.com/sofa-framework/Regression/pull/64]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if