Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1345376: SnowflakeDDLCompiler overrides get_identity_options but doesn't use it anywhere #494

Open
DanielTatarkin opened this issue Apr 24, 2024 · 1 comment
Open

SNOW-1345376: SnowflakeDDLCompiler overrides get_identity_options but doesn't use it anywhere #494

DanielTatarkin opened this issue Apr 24, 2024 · 1 comment
Assignees
@sfc-gh-dszmolka
Labels
bug Something isn't working status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team

Comments

@DanielTatarkin
Copy link
Contributor

Please answer these questions before submitting your issue. Thanks!

  1. What version of Python are you using?

    Python 3.9.X

  2. What operating system and processor architecture are you using?

    macOS-14.4.1-arm64-arm-64bit

  3. What are the component versions in the environment (pip freeze)?

    unrelated

  4. What did you do?

Creating SQLAlchemy ORM models with AUTOINCREMENT | IDENTITY sequence does not read identity options in order to apply them to SEQUENCE objects or Columns with AUTOINCREMENT | IDENTITY.

  1. What did you expect to see?

    Identity options should be set on SEQUENCE objects and/or Columns with AUTOINCREMENT | IDENTITY.

    See examples:

  1. Can you set logging to DEBUG and collect the logs?

    N/A
@DanielTatarkin DanielTatarkin added bug Something isn't working needs triage labels Apr 24, 2024
@github-actions github-actions bot changed the title SnowflakeDDLCompiler overrides get_identity_options but doesn't use it anywhere SNOW-1345376: SnowflakeDDLCompiler overrides get_identity_options but doesn't use it anywhere Apr 24, 2024
@DanielTatarkin DanielTatarkin mentioned this issue Apr 24, 2024
Merged
4 tasks
@sfc-gh-dszmolka
Copy link

hi - thank you for raising this and also for the suggested solution, appreciated! we'll review.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team and removed needs triage labels Apr 25, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-dszmolka sfc-gh-dszmolka

Labels
bug Something isn't working status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanielTatarkin @sfc-gh-dszmolka