Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1004630: Combine-coverage should only run if build succeeded #1849

Open
sfc-gh-mkeller opened this issue Jan 10, 2024 · 0 comments
Open

SNOW-1004630: Combine-coverage should only run if build succeeded #1849

sfc-gh-mkeller opened this issue Jan 10, 2024 · 0 comments
Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team

Comments

@sfc-gh-mkeller
Copy link
Collaborator

snowflake-connector-python/.github/workflows/build_test.yml

Line 332 in ca8a580

if: ${{ success() || failure() }}

Combine-coverage should run when tests pass, or fail. However; there's no point in running it if a build failed and tests won't even start.
@github-actions github-actions bot changed the title Combine-coverage should only run if build succeeded SNOW-1004630: Combine-coverage should only run if build succeeded Jan 10, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfc-gh-mkeller @sfc-gh-dszmolka