Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The response of the authentication should contain information about the anonymous status #51

Open
schettn opened this issue Jun 12, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@schettn
Copy link
Member

schettn commented Jun 12, 2020

Is your feature request related to a problem? Please describe.
Currently when calling session.begin() it is not clear wether you are logged in as an anonymous user or not.
The response contains the username and it would be possible to check if the username is the same as the anonymous user, but this would definitely create a large potential for error.

Let's look at an example:
The change of the anonymous username in v0.2.0 would be a breaking change cause every user of the snek-client had to adjust there codebase on the new username.

Describe the solution you'd like
It would be a lot cooler if the response of session.begin() would contain a boolean, let's call it anonymous which tells if I got authenticated as anonymous or not.

@schettn schettn added the enhancement New feature or request label Jun 12, 2020
@schettn schettn added this to the v0.1.x milestone Jun 12, 2020
@schettn schettn self-assigned this Jun 12, 2020
@schettn schettn modified the milestones: v0.1.x, v0.2.0 Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant