You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Error returns duplicate information since the error source is included in both the Display and Error::source, for example logging errors with tracing produce the following:
2022-11-04T19:05:01.777878Z WARN crate: error=websocket errored error.sources=[IO error: unexpected end of file, unexpected end of file]
It would be nice to either include downstream error information in just the Error::source (leaving Display with "IO error") as discussed here: dtolnay/thiserror#38 or to not implement Error::source for the Error::Io variant.
The text was updated successfully, but these errors were encountered:
Thank you for pointing on this. This is one of artifacts coming from pre-2018 Rust and from early versions of Tungstenite. This definitely needs reworking.
Error
returns duplicate information since the error source is included in both theDisplay
andError::source
, for example logging errors with tracing produce the following:It would be nice to either include downstream error information in just the
Error::source
(leavingDisplay
with "IO error") as discussed here: dtolnay/thiserror#38 or to not implementError::source
for theError::Io
variant.The text was updated successfully, but these errors were encountered: