Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues from npm audit #698

Closed
bonustrack opened this issue Sep 26, 2021 · 9 comments · Fixed by #990
Closed

Fix issues from npm audit #698

bonustrack opened this issue Sep 26, 2021 · 9 comments · Fixed by #990
Assignees
Labels
help wanted Extra attention is needed

Comments

@bonustrack
Copy link
Member

We should fix issue from npm audit

https://github.com/snapshot-labs/snapshot/security/dependabot

image

@bonustrack bonustrack added help wanted Extra attention is needed 50 USDC labels Sep 26, 2021
@sarmatdev
Copy link
Contributor

I would try to solve this issue, but I do not have access to the dependabot page

@midgerate
Copy link
Contributor

@sarmatdev Isn't the screenshot above enough?

@snapshot-labs snapshot-labs deleted a comment from W420-AB Sep 30, 2021
@midgerate
Copy link
Contributor

@sarmatdev are you still doing this?

@sarmatdev
Copy link
Contributor

@sarmatdev are you still doing this?

I don't have access to the full security reports. Take this task if you want to solve it.

@midgerate
Copy link
Contributor

midgerate commented Oct 1, 2021

@bonustrack axios comes from @portis/web3 and ansi-regex comes from eslint.

portis/web3 and eslint are already the latest release possible.

I do not see what we can do here other than patching those packages

@midgerate
Copy link
Contributor

Another solution - disable portis/web3 till we have any updates from them.

@mktcode
Copy link
Collaborator

mktcode commented Oct 5, 2021

@sarmatdev you can enable security alerts in your fork. :)

@midgerate
Copy link
Contributor

take a look at yarn's resolution feature. Also submit an issue on portis/web3 to upgrade their dependencies.

@ChaituVR
Copy link
Member

ChaituVR commented Nov 1, 2021

Created a PR here portis-project/web-sdk#141 that can remove their unused dep that have this old version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants