-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Default::default instead of new in traits #230
Comments
morenol
changed the title
Use Default::default instead of new in trait
Use Default::default instead of new in traits
Nov 4, 2022
I had to implement the new() method as it looked like the best way of passing the estimators to |
gotcha, I think that we can use generics to define the type that we need to use instead of passing a blank parameter that is not used |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm submitting a
Current Behaviour:
Currently, traits in https://github.com/smartcorelib/smartcore/blob/development/src/api.rs#L24 requires implementation of
fn new() -> Self;
, I think that instead we should rely on Default::default,Do you want to work on this issue?
Yes
Any thoughts?
The text was updated successfully, but these errors were encountered: