Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for frame throttling on X11 #5050

Open
tronical opened this issue Apr 12, 2024 · 0 comments
Open

Add support for frame throttling on X11 #5050

tronical opened this issue Apr 12, 2024 · 0 comments
Labels
a:backend-winit Winit backend (mS,mO) a:platform-linux issue specific to Linux, X11 or wayland (mO,bT) bug Something isn't working

Comments

@tronical
Copy link
Member

tronical commented Apr 12, 2024 •
edited

As seen in #5036, on X11 when calling request_redraw() or when modifying a property that changes what's on the screen, we re-render even if the window is not visible on the screen.

We should not do that. This is already solved for Wayland by use of winit's API in #4200.

The same issue also exists on macOS with #4025.

This likely needs support in winit.

FWIW, WindowEvent::Occluded is not enough, or at least open box send it.
@tronical tronical added bug Something isn't working a:platform-linux issue specific to Linux, X11 or wayland (mO,bT) a:backend-winit Winit backend (mS,mO) labels Apr 12, 2024
@tronical tronical mentioned this issue Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:backend-winit Winit backend (mS,mO) a:platform-linux issue specific to Linux, X11 or wayland (mO,bT) bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tronical