You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm quite new to Akka so may have misunderstood something, but I think that this means all of the ActorRefs created by the SlackRtmClient will sit at the top level of the actor hierarchy?
Ideally, I would like these to be able to sit underneath other actors in the actor hierarchy. I think this would be possible by changing the implicit ActorSystem to be an implicit ActorRefFactory so that we can use the actor context instead of the system. I couldn't see anywhere where it needed to explicitly be an ActorSystem but there's a good chance I missed something!
I'm happy to work on this if you think it's a good idea. Please let me know if I've missed an important point somewhere.
The text was updated successfully, but these errors were encountered:
While I understand what you mean, I don't know enough of Akka to have some say.
I suggest you create a PR. I'll review it - either myself or consult with someone more knowledgeable with Akka.
The creation of a
SlackRTMClient
requires an implicitActorSession
to be in scopeI'm quite new to Akka so may have misunderstood something, but I think that this means all of the ActorRefs created by the
SlackRtmClient
will sit at the top level of the actor hierarchy?Ideally, I would like these to be able to sit underneath other actors in the actor hierarchy. I think this would be possible by changing the implicit
ActorSystem
to be an implicitActorRefFactory
so that we can use the actor context instead of the system. I couldn't see anywhere where it needed to explicitly be anActorSystem
but there's a good chance I missed something!I'm happy to work on this if you think it's a good idea. Please let me know if I've missed an important point somewhere.
The text was updated successfully, but these errors were encountered: