-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin built time (skpm-build --watch --run) is too slow after changes in files. #266
Comments
I'm having this issue as well. I'm on Sketch 61.2 |
Another update: When I switch to using an older version of skpm/builder (
I CAN actually get fast building and running going. However, it breaks when I paste in the sample code from airbnb's react-sketchapp project. |
I am getting a super slow build from the get-go just doing |
Looking deeper, i acan see the the culprit is the "scripts": {
"build": "skpm-build", // works fine
"watch": "skpm-build --watch", // works fine
"start": "skpm-build --watch --run", // very slow
"postinstall": "npm run build && skpm-link"
}, And looks like this commit relates: |
I've run into this issue too, takes over a minute for anything to build with |
Same result with 0.7.0. |
How do I downgrade to 0.6? |
npm install --save @skpm/builder@~0.6 |
For some reason the following line seems not to evaluate to true:
So therefore the flag
Got a working react-sketchapp typescript setup using the latest Sketch 81.1 this way. |
Oh interesting. Would you be able to investigate why it's not evaluating to |
Right now it's not a priority for me so I have to postpone any further investigation at this point, I'm just happy it works for my PoC. When I start using this more frequently I might come back to it. |
Current results:
The steps that led to these results
On the first evening after installing everthing was ok, but the next day, when I was running a command: npm run start , the time between saving the event in a file and running the plugin in sketch was too long, about a minute or longer.
A link to the plugin repo: Helpify plugin
What am I doing wrong? Or what has happened and how to fix it?
The text was updated successfully, but these errors were encountered: