Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open dev tools window #23

Open
cshell7 opened this issue Dec 27, 2017 · 5 comments
Open

Can't open dev tools window #23

cshell7 opened this issue Dec 27, 2017 · 5 comments

Comments

@cshell7
Copy link

cshell7 commented Dec 27, 2017

Whenever I click on the extension it either takes me to your github page or the page for the extension. I looked for another panel in the devtool window like in your screen shot but didn't see any.

@javierfernandes
Copy link

javierfernandes commented Jan 10, 2018

Seems like the button just does that (not sure, I'm just a new user :P)

But you need to access it from the inspect window, there should be a "Reselect" tab

image

I was not seeing it at first, and I have to add setup code for reselect-tools while creating redux store

ReselectTools.getStateWith(() => store.getState())

(as it is in the README)

@skortchmark9
Copy link
Owner

skortchmark9 commented Feb 1, 2018

I don't think I set up the notifications properly in this repository. Sorry I didn't respond! @javierfernandes is correct that the button doesn't do anything, and the chrome extension will show up in the dev tools panel only if the reselect bindings have been installed in the app. (Though I think you only need the first part, createSelectorWithDependencies)

I would like to make the icon more useful - it was kinda a rushed job.

@beck
Copy link

beck commented Dec 11, 2018

Landed here too. Found it confusing that clicking the extension just opens the repo.

🤞this tool takes off.

@skortchmark9 skortchmark9 transferred this issue from skortchmark9/reselect-devtools-extension Aug 6, 2019
@skortchmark9
Copy link
Owner

skortchmark9 commented Aug 6, 2019

Moving all issues from the extension repo to the library repo, as I'm combining them (see #24). Thanks!

@skortchmark9
Copy link
Owner

skortchmark9 commented Aug 6, 2019

The right thing to do here is to mirror the behavior of the react devtools, and only enable the extension icon when the hooks are installed. See note here

Entrypoint here: https://github.com/skortchmark9/reselect-tools/blob/master/extension/chrome/extension/background.js#L2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants