Timing is expected in ms, but timing_since sends μs. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed unit test, made simpler to understand.
|
Looks good to me. |
|
We should merge this :) |
|
@tayfun this is 2.5 years old. I doubt it's getting anywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug reported in number of issues so far:
Fixes #31
Fixes #44
Fixes #93
Unit test was also measuring μs while it says it's measuring ms. Maybe the interface of the
timing_sincemethod shouldn't be seconds at all - for consistency it should be milliseconds for all timing methods. I can change it, what do you think?