-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedicated Widget Blocks #1813
Open
AlexGStapleton
wants to merge
28
commits into
develop
Choose a base branch
from
dedicated-widget-blocks
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dedicated Widget Blocks #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repalces the SiteOrigin Widgets block.
Whoops. Those two commits were added to the wrong PR. 😞 |
…o dedicated-widget-blocks # Conflicts: # compat/block-editor/widget-block.js
No longer used.
…o dedicated-widget-blocks
It's no longer possible for it to occur prior to block initialisation. Block replacement in general has also been improved.
Keywords can be added by editing the widget files and adding a comma separated list. For example: Keywords: cart, columns
…o dedicated-widget-blocks
The build script sadly doesn't understand this. :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1683
This PR removes the SiteOrigin Widgets Block in favour of dedicated blocks for all Widget Bundle widgets. It provides a migration pathway to prevent loss of settings. It also implements a number of performance improvements for form previewing and generation that will significantly improve performance, and prevent repeated request attempts.