-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Dropping sass-processor dependency #592
Comments
CSS nesting has still some issues, but for sure it will make the life easier. |
linkding mostly uses SASS because the CSS library that linkding uses (Spectre.css) is based on that, so it was a necessity to customize the SASS variables exposed by the library. It's also using some SASS helper functions, for example to modify colors. Over time I have added a lot of customizations, and Spectre.css doesn't really get any improvements anymore, so it could be an option to "eject" the Spectre related CSS, in the same step replace SASS with CSS variables, and hard-code / extract the stuff calculated by functions. Still quite a bit of effort. It would help speed up the Docker build, which seems to be 50% building lib-sass, but I don't see myself spending time on this soon. |
As evidenced here > https://twitter.com/dhh/status/1735435171342737866 MDN writes more about it > https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_nesting/Using_CSS_nesting
Modern CSS manages to nest CSS; so there shouldn't really be a need for a sass processor. You could use plain CSS.
The text was updated successfully, but these errors were encountered: